evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: das08: Avoid zero initializers in board structure

Browse source 
Don't bother initializing the `i8255_offset` and/or `i8254_offset`
members of `struct das08_board_struct` in `das08_boards[]` and
`das08_cs_boards[]` if they are zero as they are implicitly initialized
to zero anyway, and zero means the corresponding subdevices are absent.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Ian Abbott 2012-08-31 20:41:35 +01:00 • committed by Greg Kroah-Hartman
parent dd2ac5d4b7
commit 5bacadc84b
1 changed files with 0 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
drivers/staging/comedi/drivers/das08.c
View file

@ -524,7 +524,6 @@ static const struct das08_board_struct das08_boards[] = {
.ai_encoding = das08_encode12, .ai_encoding = das08_encode12,
.di_nchan = 3, .di_nchan = 3,
.do_nchan = 4, .do_nchan = 4,
.i8255_offset = 0,
.i8254_offset = 0x04, .i8254_offset = 0x04,
.iosize = 16, /* unchecked */ .iosize = 16, /* unchecked */
}, },
@ -536,7 +535,6 @@ static const struct das08_board_struct das08_boards[] = {
.ai_encoding = das08_encode12, .ai_encoding = das08_encode12,
.di_nchan = 3, .di_nchan = 3,
.do_nchan = 4, .do_nchan = 4,
.i8255_offset = 0,
.i8254_offset = 0x04, .i8254_offset = 0x04,
.iosize = 16, /* unchecked */ .iosize = 16, /* unchecked */
}, },
@ -589,8 +587,6 @@ static const struct das08_board_struct das08_boards[] = {
.ao_nbits = 12, .ao_nbits = 12,
.di_nchan = 8, .di_nchan = 8,
.do_nchan = 8, .do_nchan = 8,
.i8255_offset = 0,
.i8254_offset = 0,
.iosize = 16, /* unchecked */ .iosize = 16, /* unchecked */
}, },
{ {
@ -603,7 +599,6 @@ static const struct das08_board_struct das08_boards[] = {
.ao_nbits = 16, .ao_nbits = 16,
.di_nchan = 8, .di_nchan = 8,
.do_nchan = 8, .do_nchan = 8,
.i8255_offset = 0,
.i8254_offset = 0x04, .i8254_offset = 0x04,
.iosize = 16, /* unchecked */ .iosize = 16, /* unchecked */
}, },
@ -615,7 +610,6 @@ static const struct das08_board_struct das08_boards[] = {
.ai_encoding = das08_encode12, .ai_encoding = das08_encode12,
.di_nchan = 3, .di_nchan = 3,
.do_nchan = 4, .do_nchan = 4,
.i8255_offset = 0,
.i8254_offset = 4, .i8254_offset = 4,
.iosize = 16, /* unchecked */ .iosize = 16, /* unchecked */
}, },
@ -636,8 +630,6 @@ static const struct das08_board_struct das08_boards[] = {
.ai_encoding = das08_encode16, .ai_encoding = das08_encode16,
.di_nchan = 8, .di_nchan = 8,
.do_nchan = 8, .do_nchan = 8,
.i8255_offset = 0,
.i8254_offset = 0,
.iosize = 16, /* unchecked */ .iosize = 16, /* unchecked */
}, },
#if 0 #if 0
@ -659,7 +651,6 @@ static const struct das08_board_struct das08_boards[] = {
.ai_encoding = das08_encode12, .ai_encoding = das08_encode12,
.di_nchan = 3, .di_nchan = 3,
.do_nchan = 4, .do_nchan = 4,
.i8255_offset = 0,
.i8254_offset = 4, .i8254_offset = 4,
.iosize = 8, .iosize = 8,
}, },
@ -683,8 +674,6 @@ struct das08_board_struct das08_cs_boards[NUM_DAS08_CS_BOARDS] = {
.ai_encoding = das08_pcm_encode12, .ai_encoding = das08_pcm_encode12,
.di_nchan = 3, .di_nchan = 3,
.do_nchan = 3, .do_nchan = 3,
.i8255_offset = 0,
.i8254_offset = 0,
.iosize = 16, .iosize = 16,
}, },
/* duplicate so driver name can be used also */ /* duplicate so driver name can be used also */
@ -697,8 +686,6 @@ struct das08_board_struct das08_cs_boards[NUM_DAS08_CS_BOARDS] = {
.ai_encoding = das08_pcm_encode12, .ai_encoding = das08_pcm_encode12,
.di_nchan = 3, .di_nchan = 3,
.do_nchan = 3, .do_nchan = 3,
.i8255_offset = 0,
.i8254_offset = 0,
.iosize = 16, .iosize = 16,
}, },
}; };