evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ALSA: trident: Deletion of a check before snd_util_memhdr_free()

Browse source 
The snd_util_memhdr_free() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Markus Elfring 2014-12-02 18:52:21 +01:00 • committed by Takashi Iwai
parent 057a4a55e7
commit 5c34fdf48b
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
sound/pci/trident/trident_main.c
View file

@ -3702,8 +3702,7 @@ static int snd_trident_free(struct snd_trident *trident)
free_irq(trident->irq, trident); free_irq(trident->irq, trident);
if (trident->tlb.buffer.area) { if (trident->tlb.buffer.area) {
outl(0, TRID_REG(trident, NX_TLBC)); outl(0, TRID_REG(trident, NX_TLBC));
if (trident->tlb.memhdr) snd_util_memhdr_free(trident->tlb.memhdr);
snd_util_memhdr_free(trident->tlb.memhdr);
if (trident->tlb.silent_page.area) if (trident->tlb.silent_page.area)
snd_dma_free_pages(&trident->tlb.silent_page); snd_dma_free_pages(&trident->tlb.silent_page);
vfree(trident->tlb.shadow_entries); vfree(trident->tlb.shadow_entries);