evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ath5k: Print stats as unsigned ints.

Browse source 
The debugfs code for ath5k was printing some unsigned int
stats with %d instead of %u.  This meant that you could see
negative numbers instead of a clean wrap.

Signed-off-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Ben Greear 2010-11-08 10:50:03 -08:00 • committed by John W. Linville
parent 8c5765fda4
commit 5d882c97e2
1 changed files with 15 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
drivers/net/wireless/ath/ath5k/debug.c
View file

@ -554,63 +554,63 @@ static ssize_t read_file_frameerrors(struct file *file, char __user *user_buf,
len += snprintf(buf+len, sizeof(buf)-len, len += snprintf(buf+len, sizeof(buf)-len,
"RX\n---------------------\n"); "RX\n---------------------\n");
len += snprintf(buf+len, sizeof(buf)-len, "CRC\t%d\t(%d%%)\n", len += snprintf(buf+len, sizeof(buf)-len, "CRC\t%u\t(%u%%)\n",
st->rxerr_crc, st->rxerr_crc,
st->rx_all_count > 0 ? st->rx_all_count > 0 ?
st->rxerr_crc*100/st->rx_all_count : 0); st->rxerr_crc*100/st->rx_all_count : 0);
len += snprintf(buf+len, sizeof(buf)-len, "PHY\t%d\t(%d%%)\n", len += snprintf(buf+len, sizeof(buf)-len, "PHY\t%u\t(%u%%)\n",
st->rxerr_phy, st->rxerr_phy,
st->rx_all_count > 0 ? st->rx_all_count > 0 ?
st->rxerr_phy*100/st->rx_all_count : 0); st->rxerr_phy*100/st->rx_all_count : 0);
for (i = 0; i < 32; i++) { for (i = 0; i < 32; i++) {
if (st->rxerr_phy_code[i]) if (st->rxerr_phy_code[i])
len += snprintf(buf+len, sizeof(buf)-len, len += snprintf(buf+len, sizeof(buf)-len,
" phy_err[%d]\t%d\n", " phy_err[%u]\t%u\n",
i, st->rxerr_phy_code[i]); i, st->rxerr_phy_code[i]);
} }
len += snprintf(buf+len, sizeof(buf)-len, "FIFO\t%d\t(%d%%)\n", len += snprintf(buf+len, sizeof(buf)-len, "FIFO\t%u\t(%u%%)\n",
st->rxerr_fifo, st->rxerr_fifo,
st->rx_all_count > 0 ? st->rx_all_count > 0 ?
st->rxerr_fifo*100/st->rx_all_count : 0); st->rxerr_fifo*100/st->rx_all_count : 0);
len += snprintf(buf+len, sizeof(buf)-len, "decrypt\t%d\t(%d%%)\n", len += snprintf(buf+len, sizeof(buf)-len, "decrypt\t%u\t(%u%%)\n",
st->rxerr_decrypt, st->rxerr_decrypt,
st->rx_all_count > 0 ? st->rx_all_count > 0 ?
st->rxerr_decrypt*100/st->rx_all_count : 0); st->rxerr_decrypt*100/st->rx_all_count : 0);
len += snprintf(buf+len, sizeof(buf)-len, "MIC\t%d\t(%d%%)\n", len += snprintf(buf+len, sizeof(buf)-len, "MIC\t%u\t(%u%%)\n",
st->rxerr_mic, st->rxerr_mic,
st->rx_all_count > 0 ? st->rx_all_count > 0 ?
st->rxerr_mic*100/st->rx_all_count : 0); st->rxerr_mic*100/st->rx_all_count : 0);
len += snprintf(buf+len, sizeof(buf)-len, "process\t%d\t(%d%%)\n", len += snprintf(buf+len, sizeof(buf)-len, "process\t%u\t(%u%%)\n",
st->rxerr_proc, st->rxerr_proc,
st->rx_all_count > 0 ? st->rx_all_count > 0 ?
st->rxerr_proc*100/st->rx_all_count : 0); st->rxerr_proc*100/st->rx_all_count : 0);
len += snprintf(buf+len, sizeof(buf)-len, "jumbo\t%d\t(%d%%)\n", len += snprintf(buf+len, sizeof(buf)-len, "jumbo\t%u\t(%u%%)\n",
st->rxerr_jumbo, st->rxerr_jumbo,
st->rx_all_count > 0 ? st->rx_all_count > 0 ?
st->rxerr_jumbo*100/st->rx_all_count : 0); st->rxerr_jumbo*100/st->rx_all_count : 0);
len += snprintf(buf+len, sizeof(buf)-len, "[RX all\t%d]\n", len += snprintf(buf+len, sizeof(buf)-len, "[RX all\t%u]\n",
st->rx_all_count); st->rx_all_count);
len += snprintf(buf+len, sizeof(buf)-len, "RX-all-bytes\t%d\n", len += snprintf(buf+len, sizeof(buf)-len, "RX-all-bytes\t%u\n",
st->rx_bytes_count); st->rx_bytes_count);
len += snprintf(buf+len, sizeof(buf)-len, len += snprintf(buf+len, sizeof(buf)-len,
"\nTX\n---------------------\n"); "\nTX\n---------------------\n");
len += snprintf(buf+len, sizeof(buf)-len, "retry\t%d\t(%d%%)\n", len += snprintf(buf+len, sizeof(buf)-len, "retry\t%u\t(%u%%)\n",
st->txerr_retry, st->txerr_retry,
st->tx_all_count > 0 ? st->tx_all_count > 0 ?
st->txerr_retry*100/st->tx_all_count : 0); st->txerr_retry*100/st->tx_all_count : 0);
len += snprintf(buf+len, sizeof(buf)-len, "FIFO\t%d\t(%d%%)\n", len += snprintf(buf+len, sizeof(buf)-len, "FIFO\t%u\t(%u%%)\n",
st->txerr_fifo, st->txerr_fifo,
st->tx_all_count > 0 ? st->tx_all_count > 0 ?
st->txerr_fifo*100/st->tx_all_count : 0); st->txerr_fifo*100/st->tx_all_count : 0);
len += snprintf(buf+len, sizeof(buf)-len, "filter\t%d\t(%d%%)\n", len += snprintf(buf+len, sizeof(buf)-len, "filter\t%u\t(%u%%)\n",
st->txerr_filt, st->txerr_filt,
st->tx_all_count > 0 ? st->tx_all_count > 0 ?
st->txerr_filt*100/st->tx_all_count : 0); st->txerr_filt*100/st->tx_all_count : 0);
len += snprintf(buf+len, sizeof(buf)-len, "[TX all\t%d]\n", len += snprintf(buf+len, sizeof(buf)-len, "[TX all\t%u]\n",
st->tx_all_count); st->tx_all_count);
len += snprintf(buf+len, sizeof(buf)-len, "TX-all-bytes\t%d\n", len += snprintf(buf+len, sizeof(buf)-len, "TX-all-bytes\t%u\n",
st->tx_bytes_count); st->tx_bytes_count);
if (len > sizeof(buf)) if (len > sizeof(buf))