evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gpio/omap: fix possible memory leak in omap2_gpio_dev_init()

Browse source 
pdata and pdata->regs have been allocated in this function and
should be freed before leaving it, and in the other error handling
cases too.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Kevin Hilman <khilman@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
This commit is contained in:
Wei Yongjun 2012-09-03 20:42:27 +08:00 • committed by Tony Lindgren
parent 55d512e245
commit 5e40b1c1cc
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
arch/arm/mach-omap2/gpio.c
View file

@ -60,6 +60,7 @@ static int __init omap2_gpio_dev_init(struct omap_hwmod *oh, void *unused)
pdata->regs = kzalloc(sizeof(struct omap_gpio_reg_offs), GFP_KERNEL); pdata->regs = kzalloc(sizeof(struct omap_gpio_reg_offs), GFP_KERNEL);
if (!pdata->regs) { if (!pdata->regs) {
pr_err("gpio%d: Memory allocation failed\n", id); pr_err("gpio%d: Memory allocation failed\n", id);
kfree(pdata);
return -ENOMEM; return -ENOMEM;
} }
@ -121,6 +122,7 @@ static int __init omap2_gpio_dev_init(struct omap_hwmod *oh, void *unused)
break; break;
default: default:
WARN(1, "Invalid gpio bank_type\n"); WARN(1, "Invalid gpio bank_type\n");
kfree(pdata->regs);
kfree(pdata); kfree(pdata);
return -EINVAL; return -EINVAL;
} }