evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

drivers/iommu: remove unnecessary platform_set_drvdata()

Browse source 
The driver core clears the driver data to NULL after device_release or
on probe failure.  Thus, it is not needed to manually clear the device
driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: David Brown <davidb@codeaurora.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Suman Anna <s-anna@ti.com>
Acked-by: Libo Chen <libo.chen@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Jingoo Han 2013-09-11 14:19:43 -07:00 • committed by Linus Torvalds
parent ffd29195ed
commit 5e42781caf
2 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/iommu/msm_iommu_dev.c
View file

@ -282,7 +282,6 @@ static int msm_iommu_remove(struct platform_device *pdev)
clk_put(drv->pclk); clk_put(drv->pclk);
memset(drv, 0, sizeof(*drv)); memset(drv, 0, sizeof(*drv));
kfree(drv); kfree(drv);
platform_set_drvdata(pdev, NULL);
} }
return 0; return 0;
} }
@ -366,7 +365,6 @@ static int msm_iommu_ctx_remove(struct platform_device *pdev)
if (drv) { if (drv) {
memset(drv, 0, sizeof(struct msm_iommu_ctx_drvdata)); memset(drv, 0, sizeof(struct msm_iommu_ctx_drvdata));
kfree(drv); kfree(drv);
platform_set_drvdata(pdev, NULL);
} }
return 0; return 0;
} }

2
drivers/iommu/omap-iommu.c
View file

@ -1008,8 +1008,6 @@ static int omap_iommu_remove(struct platform_device *pdev)
struct resource *res; struct resource *res;
struct omap_iommu *obj = platform_get_drvdata(pdev); struct omap_iommu *obj = platform_get_drvdata(pdev);
platform_set_drvdata(pdev, NULL);
iopgtable_clear_entry_all(obj); iopgtable_clear_entry_all(obj);
irq = platform_get_irq(pdev, 0); irq = platform_get_irq(pdev, 0);