evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

drivers: soc: set apr handle to NULL on glink_open error

Browse source 
After sub system restart, opening glink channel while
lpass transport is not up results in failure and returns
error pointer. APR glink client although returns error for
the first glink command, does not set the apr handle to NULL
and incorrectly assumes err pointer as a valid handle when
opening the channel again.

Fix this by updating the apr handle to NULL when glink_open()
fails.

Change-Id: I53a219b1ebed5bc3593d500d80d580aac6431ab5
Signed-off-by: Shiv Maliyappanahalli <smaliyap@codeaurora.org>
This commit is contained in:
Shiv Maliyappanahalli 2016-07-08 13:00:23 -07:00 • committed by Kyle Yan
parent f55cbb3385
commit 5f0a4b1fef
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/soc/qcom/qdsp6v2/apr_tal_glink.c
View file

@ -330,6 +330,7 @@ struct apr_svc_ch_dev *apr_tal_open(uint32_t clnt, uint32_t dest, uint32_t dl,
if (IS_ERR_OR_NULL(apr_ch->handle)) { if (IS_ERR_OR_NULL(apr_ch->handle)) {
pr_err("%s: glink_open failed %s\n", __func__, pr_err("%s: glink_open failed %s\n", __func__,
svc_names[dest][clnt]); svc_names[dest][clnt]);
apr_ch->handle = NULL;
goto unlock; goto unlock;
} }