evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

uprobes: Remove redundant lock_page/unlock_page

Browse source 
Since read_opcode() reads from the referenced page and doesnt modify
the page contents nor the page attributes, there is no need to lock
the page.

Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
This commit is contained in:
Srikar Dronamraju 2012-06-01 14:49:50 +05:30 • committed by Oleg Nesterov
parent 508dc4f8ee
commit 61e1d39498
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
kernel/events/uprobes.c
View file

@ -280,12 +280,10 @@ static int read_opcode(struct mm_struct *mm, unsigned long vaddr, uprobe_opcode_
if (ret <= 0) if (ret <= 0)
return ret; return ret;
lock_page(page);
vaddr_new = kmap_atomic(page); vaddr_new = kmap_atomic(page);
vaddr &= ~PAGE_MASK; vaddr &= ~PAGE_MASK;
memcpy(opcode, vaddr_new + vaddr, UPROBE_SWBP_INSN_SIZE); memcpy(opcode, vaddr_new + vaddr, UPROBE_SWBP_INSN_SIZE);
kunmap_atomic(vaddr_new); kunmap_atomic(vaddr_new);
unlock_page(page);
put_page(page); put_page(page);