evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mvsas: fix misleading indentation

Browse source 
commit 7789cd39274c51bf475411fe22a8ee7255082809 upstream.

Fix a smatch warning:
drivers/scsi/mvsas/mv_sas.c:740 mvs_task_prep() warn: curly braces intended?

The code is correct, the indention is misleading. When the device is not
ready we want to return SAS_PHY_DOWN. But current indentation makes it
look like we only do so in the else branch of if (mvi_dev).

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Luis de Bethencourt 2015-11-30 14:32:17 +00:00 • committed by Greg Kroah-Hartman
parent 72ca0ab306
commit 61fbad6a28
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/scsi/mvsas/mv_sas.c
View file

@ -737,8 +737,8 @@ static int mvs_task_prep(struct sas_task *task, struct mvs_info *mvi, int is_tmf
mv_dprintk("device %016llx not ready.\n", mv_dprintk("device %016llx not ready.\n",
SAS_ADDR(dev->sas_addr)); SAS_ADDR(dev->sas_addr));
rc = SAS_PHY_DOWN; rc = SAS_PHY_DOWN;
return rc; return rc;
} }
tei.port = dev->port->lldd_port; tei.port = dev->port->lldd_port;
if (tei.port && !tei.port->port_attached && !tmf) { if (tei.port && !tei.port->port_attached && !tmf) {