evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

netfilter: nf_queue: fix NF_STOLEN skb leak

Browse source 
commit 3bc38712e3 (handle NF_STOP and unknown verdicts in
nf_reinject) was a partial fix to packet leaks.

If user asks NF_STOLEN status, we must free the skb as well.

Reported-by: Afi Gjermund <afigjermund@gmail.com>
Signed-off-by: Eric DUmazet <eric.dumazet@gmail.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
This commit is contained in:
Eric Dumazet 2010-02-19 15:28:38 +01:00 • committed by Patrick McHardy
parent a88e22adf5
commit 64507fdbc2
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
net/netfilter/nf_queue.c
View file

@ -265,7 +265,6 @@ void nf_reinject(struct nf_queue_entry *entry, unsigned int verdict)
local_bh_disable(); local_bh_disable();
entry->okfn(skb); entry->okfn(skb);
local_bh_enable(); local_bh_enable();
case NF_STOLEN:
break; break;
case NF_QUEUE: case NF_QUEUE:
if (!__nf_queue(skb, elem, entry->pf, entry->hook, if (!__nf_queue(skb, elem, entry->pf, entry->hook,
@ -273,6 +272,7 @@ void nf_reinject(struct nf_queue_entry *entry, unsigned int verdict)
verdict >> NF_VERDICT_BITS)) verdict >> NF_VERDICT_BITS))
goto next_hook; goto next_hook;
break; break;
case NF_STOLEN:
default: default:
kfree_skb(skb); kfree_skb(skb);
} }