evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

iio: hid-sensor: Return proper error if kmemdup fails

Browse source 
Return -ENOMEM instead of 0 if kmemdup fails.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
This commit is contained in:
Axel Lin 2012-10-27 16:03:00 +01:00 • committed by Jonathan Cameron
parent 95273f8952
commit 64ebe955f9
4 changed files with 11 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/iio/accel/hid-sensor-accel-3d.c
View file

@ -306,10 +306,10 @@ static int __devinit hid_accel_3d_probe(struct platform_device *pdev)
goto error_free_dev; goto error_free_dev;
} }
channels = kmemdup(accel_3d_channels, channels = kmemdup(accel_3d_channels, sizeof(accel_3d_channels),
sizeof(accel_3d_channels),
GFP_KERNEL); GFP_KERNEL);
if (!channels) { if (!channels) {
ret = -ENOMEM;
dev_err(&pdev->dev, "failed to duplicate channels\n"); dev_err(&pdev->dev, "failed to duplicate channels\n");
goto error_free_dev; goto error_free_dev;
} }

4
drivers/iio/gyro/hid-sensor-gyro-3d.c
View file

@ -306,10 +306,10 @@ static int __devinit hid_gyro_3d_probe(struct platform_device *pdev)
goto error_free_dev; goto error_free_dev;
} }
channels = kmemdup(gyro_3d_channels, channels = kmemdup(gyro_3d_channels, sizeof(gyro_3d_channels),
sizeof(gyro_3d_channels),
GFP_KERNEL); GFP_KERNEL);
if (!channels) { if (!channels) {
ret = -ENOMEM;
dev_err(&pdev->dev, "failed to duplicate channels\n"); dev_err(&pdev->dev, "failed to duplicate channels\n");
goto error_free_dev; goto error_free_dev;
} }

5
drivers/iio/light/hid-sensor-als.c
View file

@ -272,10 +272,9 @@ static int __devinit hid_als_probe(struct platform_device *pdev)
goto error_free_dev; goto error_free_dev;
} }
channels = kmemdup(als_channels, channels = kmemdup(als_channels, sizeof(als_channels), GFP_KERNEL);
sizeof(als_channels),
GFP_KERNEL);
if (!channels) { if (!channels) {
ret = -ENOMEM;
dev_err(&pdev->dev, "failed to duplicate channels\n"); dev_err(&pdev->dev, "failed to duplicate channels\n");
goto error_free_dev; goto error_free_dev;
} }

4
drivers/iio/magnetometer/hid-sensor-magn-3d.c
View file

@ -307,10 +307,10 @@ static int __devinit hid_magn_3d_probe(struct platform_device *pdev)
goto error_free_dev; goto error_free_dev;
} }
channels = kmemdup(magn_3d_channels, channels = kmemdup(magn_3d_channels, sizeof(magn_3d_channels),
sizeof(magn_3d_channels),
GFP_KERNEL); GFP_KERNEL);
if (!channels) { if (!channels) {
ret = -ENOMEM;
dev_err(&pdev->dev, "failed to duplicate channels\n"); dev_err(&pdev->dev, "failed to duplicate channels\n");
goto error_free_dev; goto error_free_dev;
} }