evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

dma: at_hdmac: fix invalid remaining bytes detection

Browse source 
Found using smatch:
drivers/dma/at_hdmac.c:299 atc_get_bytes_left() warn: unsigned
'atchan->remain_desc' is never less than zero.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
This commit is contained in:
Alexandre Belloni 2014-08-01 18:51:46 +02:00 • committed by Vinod Koul
parent cfc6abc3f1
commit 6758ddafad
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/dma/at_hdmac.c
View file

@ -294,14 +294,16 @@ static int atc_get_bytes_left(struct dma_chan *chan)
ret = -EINVAL; ret = -EINVAL;
goto out; goto out;
} }
atchan->remain_desc -= (desc_cur->lli.ctrla & ATC_BTSIZE_MAX)
<< (desc_first->tx_width); count = (desc_cur->lli.ctrla & ATC_BTSIZE_MAX)
if (atchan->remain_desc < 0) { << desc_first->tx_width;
if (atchan->remain_desc < count) {
ret = -EINVAL; ret = -EINVAL;
goto out; goto out;
} else {
ret = atchan->remain_desc;
} }
atchan->remain_desc -= count;
ret = atchan->remain_desc;
} else { } else {
/* /*
* Get residual bytes when current * Get residual bytes when current