evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

genirq: Minor readablity improvement in irq_wake_thread()

Browse source 
exit_irq_thread() clears IRQTF_RUNTHREAD flag and drops the thread's bit in
desc->threads_oneshot then. The bit must not be set again in between and it
does not, since irq_wake_thread() sees PF_EXITING flag first and returns.

Due to above the order or checking PF_EXITING and IRQTF_RUNTHREAD flags in
irq_wake_thread() is important. This change just makes it more visible in the
source code.

Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Link: http://lkml.kernel.org/r/20120321162212.GO24806@dhcp-26-207.brq.redhat.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
This commit is contained in:
Alexander Gordeev 2012-03-21 17:22:13 +01:00 • committed by Thomas Gleixner
parent b5174fa3a7
commit 69592db298
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
kernel/irq/handle.c
View file

@ -54,14 +54,18 @@ static void warn_no_thread(unsigned int irq, struct irqaction *action)
static void irq_wake_thread(struct irq_desc *desc, struct irqaction *action) static void irq_wake_thread(struct irq_desc *desc, struct irqaction *action)
{ {
/* /*
* Wake up the handler thread for this action. In case the * In case the thread crashed and was killed we just pretend that
* thread crashed and was killed we just pretend that we * we handled the interrupt. The hardirq handler has disabled the
* handled the interrupt. The hardirq handler has disabled the * device interrupt, so no irq storm is lurking.
* device interrupt, so no irq storm is lurking. If the */
if (action->thread->flags & PF_EXITING)
return;
/*
* Wake up the handler thread for this action. If the
* RUNTHREAD bit is already set, nothing to do. * RUNTHREAD bit is already set, nothing to do.
*/ */
if ((action->thread->flags & PF_EXITING) || if (test_and_set_bit(IRQTF_RUNTHREAD, &action->thread_flags))
test_and_set_bit(IRQTF_RUNTHREAD, &action->thread_flags))
return; return;
/* /*