evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: ni_at_ao: use comedi_request_region()

Browse source 
Use comedi_request_region() to request the I/O region used by this
driver.

Remove the board attach noise as well as the error message when the
request_region() fails, comedi_request_reqion() will output the error
message if necessary.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2013-04-09 16:33:40 -07:00 • committed by Greg Kroah-Hartman
parent ce1edddd8c
commit 6bb3395e4b
1 changed files with 3 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
drivers/staging/comedi/drivers/ni_at_ao.c
View file

@ -337,22 +337,14 @@ static int atao_attach(struct comedi_device *dev, struct comedi_devconfig *it)
const struct atao_board *board = comedi_board(dev); const struct atao_board *board = comedi_board(dev);
struct atao_private *devpriv; struct atao_private *devpriv;
struct comedi_subdevice *s; struct comedi_subdevice *s;
unsigned long iobase;
int ao_unipolar; int ao_unipolar;
int ret; int ret;
iobase = it->options[0];
if (iobase == 0)
iobase = 0x1c0;
ao_unipolar = it->options[3]; ao_unipolar = it->options[3];
printk(KERN_INFO "comedi%d: ni_at_ao: 0x%04lx", dev->minor, iobase); ret = comedi_request_region(dev, it->options[0], ATAO_SIZE);
if (ret)
if (!request_region(iobase, ATAO_SIZE, dev->board_name)) { return ret;
printk(" I/O port conflict\n");
return -EIO;
}
dev->iobase = iobase;
devpriv = kzalloc(sizeof(*devpriv), GFP_KERNEL); devpriv = kzalloc(sizeof(*devpriv), GFP_KERNEL);
if (!devpriv) if (!devpriv)