evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

diag: Protect the decrement of number of diag clients

Browse source 
In diagchar_open() protect the decrement of number of diag clients
so that there will be no race conditions while reading the value
from other functions.

Change-Id: I0e2fb5331eec9c7bba39e7d881b69559256833a3
Signed-off-by: Sreelakshmi Gownipalli <sgownipa@codeaurora.org>
This commit is contained in:
Sreelakshmi Gownipalli 2018-01-23 13:11:41 -08:00 • committed by Gerrit - the friendly Code Review server
parent d99718532d
commit 6eb2f4f6fd
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/char/diag/diagchar_core.c
View file

@ -389,8 +389,8 @@ static int diagchar_open(struct inode *inode, struct file *file)
return -ENOMEM; return -ENOMEM;
fail: fail:
mutex_unlock(&driver->diagchar_mutex);
driver->num_clients--; driver->num_clients--;
mutex_unlock(&driver->diagchar_mutex);
pr_err_ratelimited("diag: Insufficient memory for new client"); pr_err_ratelimited("diag: Insufficient memory for new client");
return -ENOMEM; return -ENOMEM;
} }