evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ASoC: samsung: Fix return value check in s3c2412_iis_dev_probe()

Browse source 
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR(). Also remove redundant return value check of
platform_get_resource().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mark Brown <broonie@linaro.org>
This commit is contained in:
Wei Yongjun 2014-07-20 11:43:07 +08:00 • committed by Mark Brown
parent dd2380e31c
commit 71864b22f5
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
sound/soc/samsung/s3c2412-i2s.c
View file

@ -154,13 +154,9 @@ static int s3c2412_iis_dev_probe(struct platform_device *pdev)
struct resource *res; struct resource *res;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res) {
dev_err(&pdev->dev, "Can't get IO resource.\n");
return -ENOENT;
}
s3c2412_i2s.regs = devm_ioremap_resource(&pdev->dev, res); s3c2412_i2s.regs = devm_ioremap_resource(&pdev->dev, res);
if (s3c2412_i2s.regs == NULL) if (IS_ERR(s3c2412_i2s.regs))
return -ENXIO; return PTR_ERR(s3c2412_i2s.regs);
s3c2412_i2s_pcm_stereo_out.dma_addr = res->start + S3C2412_IISTXD; s3c2412_i2s_pcm_stereo_out.dma_addr = res->start + S3C2412_IISTXD;
s3c2412_i2s_pcm_stereo_in.dma_addr = res->start + S3C2412_IISRXD; s3c2412_i2s_pcm_stereo_in.dma_addr = res->start + S3C2412_IISRXD;