evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

serial: amba-pl011: fix incorrect integer size in pl011_fifo_to_tty()

Browse source 
The UART_DUMMY_DR_RX status bit is equal to (1 << 16), so a u16 is too small
to hold that value.  The result is that UART_DUMMY_DR_RX is never passed
to uart_insert_char().  This means that we're always accepting characters,
even when CREAD (in termios) is not set.

Signed-off-by: Timur Tabi <timur@codeaurora.org>
Reviewed-by: Dave Martin <Dave.Martin@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Timur Tabi 2015-10-07 15:27:16 -05:00 • committed by Greg Kroah-Hartman
parent 3e8137a185
commit 71a5cd8a4a
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/tty/serial/amba-pl011.c
View file

@ -191,8 +191,8 @@ struct uart_amba_port {
*/ */
static int pl011_fifo_to_tty(struct uart_amba_port *uap) static int pl011_fifo_to_tty(struct uart_amba_port *uap)
{ {
u16 status, ch; u16 status;
unsigned int flag, max_count = 256; unsigned int ch, flag, max_count = 256;
int fifotaken = 0; int fifotaken = 0;
while (max_count--) { while (max_count--) {