evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

adm8211: fix error return code

Browse source 
Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
Julia Lawall 2014-12-29 18:04:41 +01:00 • committed by Kalle Valo
parent d0f66df539
commit 72e121191c
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/net/wireless/adm8211.c
View file

@ -1837,6 +1837,7 @@ static int adm8211_probe(struct pci_dev *pdev,
if (!priv->map) { if (!priv->map) {
printk(KERN_ERR "%s (adm8211): Cannot map device memory\n", printk(KERN_ERR "%s (adm8211): Cannot map device memory\n",
pci_name(pdev)); pci_name(pdev));
err = -ENOMEM;
goto err_free_dev; goto err_free_dev;
} }