evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

wimax: i2400: Fix memory leak in i2400m_op_rfkill_sw_toggle

Browse source 
commit 6f3ef5c25cc762687a7341c18cbea5af54461407 upstream.

In the implementation of i2400m_op_rfkill_sw_toggle() the allocated
buffer for cmd should be released before returning. The
documentation for i2400m_msg_to_dev() says when it returns the buffer
can be reused. Meaning cmd should be released in either case. Move
kfree(cmd) before return to be reached by all execution paths.

Fixes: 2507e6ab7a9a ("wimax: i2400: fix memory leak")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Navid Emamdoost 2019-10-25 23:53:30 -05:00 • committed by Greg Kroah-Hartman
parent ec0557c7c2
commit 73128b959c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/net/wimax/i2400m/op-rfkill.c
View file

@ -142,12 +142,12 @@ int i2400m_op_rfkill_sw_toggle(struct wimax_dev *wimax_dev,
"%d\n", result); "%d\n", result);
result = 0; result = 0;
error_cmd: error_cmd:
kfree(cmd);
kfree_skb(ack_skb); kfree_skb(ack_skb);
error_msg_to_dev: error_msg_to_dev:
error_alloc: error_alloc:
d_fnend(4, dev, "(wimax_dev %p state %d) = %d\n", d_fnend(4, dev, "(wimax_dev %p state %d) = %d\n",
wimax_dev, state, result); wimax_dev, state, result);
kfree(cmd);
return result; return result;
} }