USB: udl: proper error reporting
Parsing device descriptors can fail due to a failed memory allocation. The error needs to be properly propagated to the upper layers. Signed-off-by: Oliver Neukum <oneukum@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
c78d1ecfd7
commit
737583f07e
1 changed files with 1 additions and 2 deletions
|
@ -283,7 +283,7 @@ int udl_submit_urb(struct drm_device *dev, struct urb *urb, size_t len)
|
||||||
int udl_driver_load(struct drm_device *dev, unsigned long flags)
|
int udl_driver_load(struct drm_device *dev, unsigned long flags)
|
||||||
{
|
{
|
||||||
struct udl_device *udl;
|
struct udl_device *udl;
|
||||||
int ret;
|
int ret = -ENOMEM;
|
||||||
|
|
||||||
DRM_DEBUG("\n");
|
DRM_DEBUG("\n");
|
||||||
udl = kzalloc(sizeof(struct udl_device), GFP_KERNEL);
|
udl = kzalloc(sizeof(struct udl_device), GFP_KERNEL);
|
||||||
|
@ -299,7 +299,6 @@ int udl_driver_load(struct drm_device *dev, unsigned long flags)
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!udl_alloc_urb_list(dev, WRITES_IN_FLIGHT, MAX_TRANSFER)) {
|
if (!udl_alloc_urb_list(dev, WRITES_IN_FLIGHT, MAX_TRANSFER)) {
|
||||||
ret = -ENOMEM;
|
|
||||||
DRM_ERROR("udl_alloc_urb_list failed\n");
|
DRM_ERROR("udl_alloc_urb_list failed\n");
|
||||||
goto err;
|
goto err;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Add table
Reference in a new issue