evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: gdm724x: cleanup alloc_tx_sdu_struct()

Browse source 
The kfree(t_sdu->buf) sets off a private static checker warning because
"t_sdu->buf" is always NULL.

This function just allocates two pointers so we can re-write it to be
simpler.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2014-02-18 15:18:10 +03:00 • committed by Greg Kroah-Hartman
parent a469fe1ab8
commit 75bc5fad15
1 changed files with 4 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
drivers/staging/gdm724x/gdm_usb.c
View file

@ -119,28 +119,15 @@ out:
static struct usb_tx_sdu *alloc_tx_sdu_struct(void) static struct usb_tx_sdu *alloc_tx_sdu_struct(void)
{ {
struct usb_tx_sdu *t_sdu = NULL; struct usb_tx_sdu *t_sdu;
int ret = 0;
t_sdu = kzalloc(sizeof(struct usb_tx_sdu), GFP_ATOMIC); t_sdu = kzalloc(sizeof(struct usb_tx_sdu), GFP_ATOMIC);
if (!t_sdu) { if (!t_sdu)
ret = -ENOMEM; return NULL;
goto out;
}
t_sdu->buf = kmalloc(SDU_BUF_SIZE, GFP_ATOMIC); t_sdu->buf = kmalloc(SDU_BUF_SIZE, GFP_ATOMIC);
if (!t_sdu->buf) { if (!t_sdu->buf) {
ret = -ENOMEM; kfree(t_sdu);
goto out;
}
out:
if (ret < 0) {
if (t_sdu) {
kfree(t_sdu->buf);
kfree(t_sdu);
}
return NULL; return NULL;
} }