From 770519f0c07e3fd19f72320e6c818f1a9d808be0 Mon Sep 17 00:00:00 2001 From: Kees Cook Date: Thu, 10 Aug 2017 13:36:34 -0700 Subject: [PATCH] FROMLIST: pstore: Make default pstorefs root dir perms 0750 Currently only DMESG and CONSOLE record types are protected, and it isn't obvious that they are using a capability check. Instead switch to explicit root directory mode of 0750 to keep files private by default. This will allow the removal of the capability check, which was non-obvious and forces a process to have possibly too much privilege when simple post-boot chgrp for readers would be possible without it. Bug: 64503253 Change-Id: I4ee226d953227310b4c33e7a0436ba353abfde6f Signed-off-by: Kees Cook Signed-off-by: Siqi Lin (am from https://patchwork.kernel.org/patch/9894577/) --- fs/pstore/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c index 9e0bd71cf6eb..508c68d190ea 100644 --- a/fs/pstore/inode.c +++ b/fs/pstore/inode.c @@ -435,7 +435,7 @@ static int pstore_fill_super(struct super_block *sb, void *data, int silent) inode = pstore_get_inode(sb); if (inode) { - inode->i_mode = S_IFDIR | 0755; + inode->i_mode = S_IFDIR | 0750; inode->i_op = &pstore_dir_inode_operations; inode->i_fop = &simple_dir_operations; inc_nlink(inode);