evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Blackfin: fix typo in isram_write()

Browse source 
The DTEST write bit is 2, not 1.  Improve comments in the related macro
while we're here.

Signed-off-by: Robin Getz <robin.getz@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
This commit is contained in:
Robin Getz 2009-08-27 14:39:31 +00:00 • committed by Mike Frysinger
parent ba877d4491
commit 774b80229f
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
arch/blackfin/mm/isram-driver.c
View file

@ -53,10 +53,12 @@ static DEFINE_SPINLOCK(dtest_lock);
#define IADDR2DTEST(x) \ #define IADDR2DTEST(x) \
({ unsigned long __addr = (unsigned long)(x); \ ({ unsigned long __addr = (unsigned long)(x); \
(__addr & 0x47F8) | /* address bits 14 & 10:3 */ \ (__addr & 0x47F8) | /* address bits 14 & 10:3 */ \
(__addr & 0x8000) << 23 | /* Bank A/B */ \
(__addr & 0x0800) << 15 | /* address bit 11 */ \ (__addr & 0x0800) << 15 | /* address bit 11 */ \
(__addr & 0x3000) << 4 | /* address bits 13:12 */ \ (__addr & 0x3000) << 4 | /* address bits 13:12 */ \
(__addr & 0x8000) << 8 | /* address bit 15 */ \ (__addr & 0x8000) << 8 | /* address bit 15 */ \
(0x1000004); /* isram access */ \ (0x1000000) | /* instruction access = 1 */ \
(0x4); /* data array = 1 */ \
}) })
/* Takes a pointer, and returns the offset (in bits) which things should be shifted */ /* Takes a pointer, and returns the offset (in bits) which things should be shifted */
@ -73,7 +75,7 @@ static void isram_write(const void *addr, uint64_t data)
if (addr >= (void *)(L1_CODE_START + L1_CODE_LENGTH)) if (addr >= (void *)(L1_CODE_START + L1_CODE_LENGTH))
return; return;
cmd = IADDR2DTEST(addr) | 1; /* write */ cmd = IADDR2DTEST(addr) | 2; /* write */
/* /*
* Writes to DTEST_DATA[0:1] need to be atomic with write to DTEST_COMMAND * Writes to DTEST_DATA[0:1] need to be atomic with write to DTEST_COMMAND