From 777a58fa41cfb69c8f0945043ae36db66c4ecdb4 Mon Sep 17 00:00:00 2001 From: Clarence Ip Date: Fri, 8 Sep 2017 15:47:26 -0400 Subject: [PATCH] drm/msm: init enum properties to default value Initialize DRM/KMS enumeration properties to the first defined value rather than 0 since enumeration properties are meant to store the actual value rather than simply an enumeration index. Change-Id: I23dd62308a2d3a45c763090b6f0557634ed49d63 Signed-off-by: Clarence Ip --- drivers/gpu/drm/msm/msm_prop.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_prop.c b/drivers/gpu/drm/msm/msm_prop.c index 10f89de25831..02ed2b7a062f 100644 --- a/drivers/gpu/drm/msm/msm_prop.c +++ b/drivers/gpu/drm/msm/msm_prop.c @@ -340,9 +340,16 @@ void msm_property_install_enum(struct msm_property_info *info, info->property_data[property_idx].default_value = default_value; info->property_data[property_idx].force_dirty = false; + /* select first defined value for enums */ + if (!is_bitmask) + info->property_data[property_idx].default_value = + values->type; + /* always attach property, if created */ if (*prop) { - drm_object_attach_property(info->base, *prop, 0); + drm_object_attach_property(info->base, *prop, + info->property_data + [property_idx].default_value); ++info->install_count; } }