evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fs/xattr.c:getxattr(): improve handling of allocation failures

Browse source 
This allocation can be as large as 64k.

 - Add __GFP_NOWARN so the falied kmalloc() is silent

 - Fall back to vmalloc() if the kmalloc() failed

Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Sasha Levin 2012-07-30 14:39:13 -07:00 • committed by Linus Torvalds
parent 32b4560b04
commit 779302e678
1 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
fs/xattr.c
View file

@ -427,6 +427,7 @@ getxattr(struct dentry *d, const char __user *name, void __user *value,
{ {
ssize_t error; ssize_t error;
void *kvalue = NULL; void *kvalue = NULL;
void *vvalue = NULL;
char kname[XATTR_NAME_MAX + 1]; char kname[XATTR_NAME_MAX + 1];
error = strncpy_from_user(kname, name, sizeof(kname)); error = strncpy_from_user(kname, name, sizeof(kname));
@ -438,9 +439,13 @@ getxattr(struct dentry *d, const char __user *name, void __user *value,
if (size) { if (size) {
if (size > XATTR_SIZE_MAX) if (size > XATTR_SIZE_MAX)
size = XATTR_SIZE_MAX; size = XATTR_SIZE_MAX;
kvalue = kzalloc(size, GFP_KERNEL); kvalue = kzalloc(size, GFP_KERNEL | __GFP_NOWARN);
if (!kvalue) if (!kvalue) {
vvalue = vmalloc(size);
if (!vvalue)
return -ENOMEM; return -ENOMEM;
kvalue = vvalue;
}
} }
error = vfs_getxattr(d, kname, kvalue, size); error = vfs_getxattr(d, kname, kvalue, size);
@ -452,6 +457,9 @@ getxattr(struct dentry *d, const char __user *name, void __user *value,
than XATTR_SIZE_MAX bytes. Not possible. */ than XATTR_SIZE_MAX bytes. Not possible. */
error = -E2BIG; error = -E2BIG;
} }
if (vvalue)
vfree(vvalue);
else
kfree(kvalue); kfree(kvalue);
return error; return error;
} }