evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

qcom: qmi: release mutex upon qmi_svc_event_notifier_register error

Browse source 
This fixes the following smatch warning:

drivers/soc/qcom/qmi_interface.c:2019 qmi_svc_event_notifier_register()
warn: inconsistent returns 'mutex:&temp->svc_addr_list_lock'.

Change-Id: I2ada7d79a0ac6b6a14abad0cb463af491dd1c319
Signed-off-by: David Lin <dtwlin@google.com>
This commit is contained in:
David Lin 2017-04-30 16:37:27 -07:00 • committed by Timi
parent 5c51468273
commit 77e86943a6
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/soc/qcom/qmi_interface.c
View file

@ -1995,8 +1995,10 @@ int qmi_svc_event_notifier_register(uint32_t service_id,
svc_info_arr = kmalloc_array(num_servers,
sizeof(*svc_info_arr),
GFP_KERNEL);
if (!svc_info_arr)
return -ENOMEM;
if (!svc_info_arr) {
ret = -ENOMEM;
goto qmi_svc_event_notifier_register_err;
}
num_servers = msm_ipc_router_lookup_server_name(
&svc_name,
svc_info_arr,
@ -2014,6 +2016,8 @@ int qmi_svc_event_notifier_register(uint32_t service_id,
spin_unlock_irqrestore(&temp->nb_lock, flags);
}
}
qmi_svc_event_notifier_register_err:
mutex_unlock(&temp->svc_addr_list_lock);
return ret;