evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

scsi: qla4xxx: fix a potential NULL pointer dereference

Browse source 
[ Upstream commit fba1bdd2a9a93f3e2181ec1936a3c2f6b37e7ed6 ]

In case iscsi_lookup_endpoint fails, the fix returns -EINVAL to avoid NULL
pointer dereference.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org>
This commit is contained in:
Kangjie Lu 2019-03-14 01:30:59 -05:00 • committed by Greg Kroah-Hartman
parent f18c946e6c
commit 783552a986
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/scsi/qla4xxx/ql4_os.c
View file

@ -3207,6 +3207,8 @@ static int qla4xxx_conn_bind(struct iscsi_cls_session *cls_session,
if (iscsi_conn_bind(cls_session, cls_conn, is_leading)) if (iscsi_conn_bind(cls_session, cls_conn, is_leading))
return -EINVAL; return -EINVAL;
ep = iscsi_lookup_endpoint(transport_fd); ep = iscsi_lookup_endpoint(transport_fd);
if (!ep)
return -EINVAL;
conn = cls_conn->dd_data; conn = cls_conn->dd_data;
qla_conn = conn->dd_data; qla_conn = conn->dd_data;
qla_conn->qla_ep = ep->dd_data; qla_conn->qla_ep = ep->dd_data;