evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ALSA: hda: fix out-of-bound hdmi_eld.sad[] write

Browse source 
e->sad[] is declared with size ELD_MAX_SAD=16, but the guard
allows range 0-31.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Roel Kluin 2009-07-29 14:35:20 +02:00 • committed by Takashi Iwai
parent 626f5cefc6
commit 78735cffc2
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
sound/pci/hda/hda_eld.c
View file

@ -508,7 +508,7 @@ static void hdmi_write_eld_info(struct snd_info_entry *entry,
char name[64]; char name[64];
char *sname; char *sname;
long long val; long long val;
int n; unsigned int n;
while (!snd_info_get_line(buffer, line, sizeof(line))) { while (!snd_info_get_line(buffer, line, sizeof(line))) {
if (sscanf(line, "%s %llx", name, &val) != 2) if (sscanf(line, "%s %llx", name, &val) != 2)
@ -539,7 +539,7 @@ static void hdmi_write_eld_info(struct snd_info_entry *entry,
sname++; sname++;
n = 10 * n + name[4] - '0'; n = 10 * n + name[4] - '0';
} }
if (n < 0 || n > 31) /* double the CEA limit */ if (n >= ELD_MAX_SAD)
continue; continue;
if (!strcmp(sname, "_coding_type")) if (!strcmp(sname, "_coding_type"))
e->sad[n].format = val; e->sad[n].format = val;