evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

usb/atm/ueagle-atm: Don't test for NULL ptr before calling release_firmware()

Browse source 
release_firmware() deals gracefullt w/ NULL pointers, no need to check
first.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jesper Juhl 2012-04-09 22:52:26 +02:00 • committed by Greg Kroah-Hartman
parent e44fabbe7f
commit 7af395922a
1 changed files with 5 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/usb/atm/ueagle-atm.c
View file

@ -1357,10 +1357,8 @@ static int uea_stat_e1(struct uea_softc *sc)
/* release the dsp firmware as it is not needed until /* release the dsp firmware as it is not needed until
* the next failure * the next failure
*/ */
if (sc->dsp_firm) { release_firmware(sc->dsp_firm);
release_firmware(sc->dsp_firm); sc->dsp_firm = NULL;
sc->dsp_firm = NULL;
}
} }
/* always update it as atm layer could not be init when we switch to /* always update it as atm layer could not be init when we switch to
@ -1496,10 +1494,8 @@ static int uea_stat_e4(struct uea_softc *sc)
/* release the dsp firmware as it is not needed until /* release the dsp firmware as it is not needed until
* the next failure * the next failure
*/ */
if (sc->dsp_firm) { release_firmware(sc->dsp_firm);
release_firmware(sc->dsp_firm); sc->dsp_firm = NULL;
sc->dsp_firm = NULL;
}
} }
/* always update it as atm layer could not be init when we switch to /* always update it as atm layer could not be init when we switch to
@ -2240,8 +2236,7 @@ static void uea_stop(struct uea_softc *sc)
/* flush the work item, when no one can schedule it */ /* flush the work item, when no one can schedule it */
flush_work_sync(&sc->task); flush_work_sync(&sc->task);
if (sc->dsp_firm) release_firmware(sc->dsp_firm);
release_firmware(sc->dsp_firm);
uea_leaves(INS_TO_USBDEV(sc)); uea_leaves(INS_TO_USBDEV(sc));
} }