mm: add preempt points into __purge_vmap_area_lazy()
Use cond_resched_lock to avoid holding the vmap_area_lock for a potentially long time and thus creating bad latencies for various workloads. Change-Id: I36eb4d8dbd6604f52e5c463373a9754847a44bc2 [hch: split from a larger patch by Joel, wrote the crappy changelog] Link: http://lkml.kernel.org/r/1479474236-4139-11-git-send-email-hch@lst.de Signed-off-by: Joel Fernandes <joelaf@google.com> Signed-off-by: Christoph Hellwig <hch@lst.de> Tested-by: Jisheng Zhang <jszhang@marvell.com> Cc: Andrey Ryabinin <aryabinin@virtuozzo.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: John Dias <joaodias@google.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: Ingo Molnar <mingo@elte.hu> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Git-commit: 763b218ddfaf56761c19923beb7e16656f66ec62 Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git Signed-off-by: Vinayak Menon <vinmenon@codeaurora.org>
This commit is contained in:
parent
bcfa0a9140
commit
7c5d813b55
1 changed files with 9 additions and 5 deletions
14
mm/vmalloc.c
14
mm/vmalloc.c
|
@ -656,7 +656,7 @@ static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end)
|
|||
struct llist_node *valist;
|
||||
struct vmap_area *va;
|
||||
struct vmap_area *n_va;
|
||||
int nr = 0;
|
||||
bool do_free = false;
|
||||
|
||||
lockdep_assert_held(&vmap_purge_lock);
|
||||
|
||||
|
@ -666,18 +666,22 @@ static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end)
|
|||
start = va->va_start;
|
||||
if (va->va_end > end)
|
||||
end = va->va_end;
|
||||
nr += (va->va_end - va->va_start) >> PAGE_SHIFT;
|
||||
do_free = true;
|
||||
}
|
||||
|
||||
if (!nr)
|
||||
if (!do_free)
|
||||
return false;
|
||||
|
||||
atomic_sub(nr, &vmap_lazy_nr);
|
||||
flush_tlb_kernel_range(start, end);
|
||||
|
||||
spin_lock(&vmap_area_lock);
|
||||
llist_for_each_entry_safe(va, n_va, valist, purge_list)
|
||||
llist_for_each_entry_safe(va, n_va, valist, purge_list) {
|
||||
int nr = (va->va_end - va->va_start) >> PAGE_SHIFT;
|
||||
|
||||
__free_vmap_area(va);
|
||||
atomic_sub(nr, &vmap_lazy_nr);
|
||||
cond_resched_lock(&vmap_area_lock);
|
||||
}
|
||||
spin_unlock(&vmap_area_lock);
|
||||
return true;
|
||||
}
|
||||
|
|
Loading…
Add table
Reference in a new issue