evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

perf tools: Cleanup trace-event-info 'tdata' leak

Browse source 
[ Upstream commit faedbf3fd19f2511a39397f76359e4cc6ee93072 ]

Free tracing_data structure in tracing_data_get() error paths.

Fixes the following coverity complaint:

  Error: RESOURCE_LEAK (CWE-772):
  leaked_storage: Variable "tdata" going out of scope leaks the storage

Signed-off-by: Sanskriti Sharma <sansharm@redhat.com>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
Cc: Joe Lawrence <joe.lawrence@redhat.com>
Link: http://lkml.kernel.org/r/1538490554-8161-3-git-send-email-sansharm@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Sanskriti Sharma 2018-10-02 10:29:11 -04:00 • committed by Greg Kroah-Hartman
parent d05d8ef0c0
commit 7ce210a6be
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tools/perf/util/trace-event-info.c
View file

@ -507,12 +507,14 @@ struct tracing_data *tracing_data_get(struct list_head *pattrs,
"/tmp/perf-XXXXXX"); "/tmp/perf-XXXXXX");
if (!mkstemp(tdata->temp_file)) { if (!mkstemp(tdata->temp_file)) {
pr_debug("Can't make temp file"); pr_debug("Can't make temp file");
free(tdata);
return NULL; return NULL;
} }
temp_fd = open(tdata->temp_file, O_RDWR); temp_fd = open(tdata->temp_file, O_RDWR);
if (temp_fd < 0) { if (temp_fd < 0) {
pr_debug("Can't read '%s'", tdata->temp_file); pr_debug("Can't read '%s'", tdata->temp_file);
free(tdata);
return NULL; return NULL;
} }