x86: Make it so that __pa_symbol can only process kernel symbols on x86_64
I submitted an earlier patch that make __phys_addr an inline. This obviously results in an increase in the code size. One step I can take to reduce that is to make it so that the __pa_symbol call does a direct translation for kernel addresses instead of covering all of virtual memory. On my system this reduced the size for __pa_symbol from 5 instructions totalling 30 bytes to 3 instructions totalling 16 bytes. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Link: http://lkml.kernel.org/r/20121116215356.8521.92472.stgit@ahduyck-cp1.jf.intel.com Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
This commit is contained in:
parent
0bdf525f04
commit
7d74275d39
4 changed files with 17 additions and 1 deletions
|
@ -44,7 +44,8 @@ static inline void copy_user_page(void *to, void *from, unsigned long vaddr,
|
||||||
* case properly. Once all supported versions of gcc understand it, we can
|
* case properly. Once all supported versions of gcc understand it, we can
|
||||||
* remove this Voodoo magic stuff. (i.e. once gcc3.x is deprecated)
|
* remove this Voodoo magic stuff. (i.e. once gcc3.x is deprecated)
|
||||||
*/
|
*/
|
||||||
#define __pa_symbol(x) __pa(__phys_reloc_hide((unsigned long)(x)))
|
#define __pa_symbol(x) \
|
||||||
|
__phys_addr_symbol(__phys_reloc_hide((unsigned long)(x)))
|
||||||
|
|
||||||
#define __va(x) ((void *)((unsigned long)(x)+PAGE_OFFSET))
|
#define __va(x) ((void *)((unsigned long)(x)+PAGE_OFFSET))
|
||||||
|
|
||||||
|
|
|
@ -15,6 +15,7 @@ extern unsigned long __phys_addr(unsigned long);
|
||||||
#else
|
#else
|
||||||
#define __phys_addr(x) __phys_addr_nodebug(x)
|
#define __phys_addr(x) __phys_addr_nodebug(x)
|
||||||
#endif
|
#endif
|
||||||
|
#define __phys_addr_symbol(x) __phys_addr(x)
|
||||||
#define __phys_reloc_hide(x) RELOC_HIDE((x), 0)
|
#define __phys_reloc_hide(x) RELOC_HIDE((x), 0)
|
||||||
|
|
||||||
#ifdef CONFIG_FLATMEM
|
#ifdef CONFIG_FLATMEM
|
||||||
|
|
|
@ -21,8 +21,11 @@ static inline unsigned long __phys_addr_nodebug(unsigned long x)
|
||||||
|
|
||||||
#ifdef CONFIG_DEBUG_VIRTUAL
|
#ifdef CONFIG_DEBUG_VIRTUAL
|
||||||
extern unsigned long __phys_addr(unsigned long);
|
extern unsigned long __phys_addr(unsigned long);
|
||||||
|
extern unsigned long __phys_addr_symbol(unsigned long);
|
||||||
#else
|
#else
|
||||||
#define __phys_addr(x) __phys_addr_nodebug(x)
|
#define __phys_addr(x) __phys_addr_nodebug(x)
|
||||||
|
#define __phys_addr_symbol(x) \
|
||||||
|
((unsigned long)(x) - __START_KERNEL_map + phys_base)
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
#define __phys_reloc_hide(x) (x)
|
#define __phys_reloc_hide(x) (x)
|
||||||
|
|
|
@ -28,6 +28,17 @@ unsigned long __phys_addr(unsigned long x)
|
||||||
return x;
|
return x;
|
||||||
}
|
}
|
||||||
EXPORT_SYMBOL(__phys_addr);
|
EXPORT_SYMBOL(__phys_addr);
|
||||||
|
|
||||||
|
unsigned long __phys_addr_symbol(unsigned long x)
|
||||||
|
{
|
||||||
|
unsigned long y = x - __START_KERNEL_map;
|
||||||
|
|
||||||
|
/* only check upper bounds since lower bounds will trigger carry */
|
||||||
|
VIRTUAL_BUG_ON(y >= KERNEL_IMAGE_SIZE);
|
||||||
|
|
||||||
|
return y + phys_base;
|
||||||
|
}
|
||||||
|
EXPORT_SYMBOL(__phys_addr_symbol);
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
bool __virt_addr_valid(unsigned long x)
|
bool __virt_addr_valid(unsigned long x)
|
||||||
|
|
Loading…
Add table
Reference in a new issue