evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

nfsd4: fail when delegreturn gets a non-delegation stateid

Browse source 
Previous cleanup reveals an obvious (though harmless) bug: when
delegreturn gets a stateid that isn't for a delegation, it should return
an error rather than doing nothing.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
This commit is contained in:
J. Bruce Fields 2009-02-21 13:32:28 -08:00
parent 203a8c8e66
commit 7e0f7cf582
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
fs/nfsd/nfs4state.c
View file

@ -2418,10 +2418,9 @@ nfsd4_delegreturn(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
status = nfserr_stale_stateid; status = nfserr_stale_stateid;
if (STALE_STATEID(stateid)) if (STALE_STATEID(stateid))
goto out; goto out;
status = nfs_ok; status = nfserr_bad_stateid;
if (!is_delegation_stateid(stateid)) if (!is_delegation_stateid(stateid))
goto out; goto out;
status = nfserr_bad_stateid;
dp = find_delegation_stateid(inode, stateid); dp = find_delegation_stateid(inode, stateid);
if (!dp) if (!dp)
goto out; goto out;