evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[media] s5p-fimc: Add missing static storage class specifiers

Browse source 
Fixes the following sparse warnings:

drivers/media/video/s5p-fimc/fimc-lite-reg.c:218:6: warning: symbol
'flite_hw_set_out_order' was not declared. Should it be static?

drivers/media/video/s5p-fimc/fimc-mdevice.c:183:5: warning: symbol '__fimc_pipeline_shutdown' was not declared. Should it be static?
drivers/media/video/s5p-fimc/fimc-mdevice.c:1013:12: warning: symbol 'fimc_md_init' was not declared. Should it be static?
drivers/media/video/s5p-fimc/fimc-mdevice.c:1024:13: warning: symbol 'fimc_md_exit' was not declared. Should it be static?

drivers/media/video/s5p-fimc/fimc-core.c:466:5: warning: symbol 'fimc_set_color_effect' was not declared. Should it be static?

drivers/media/video/s5p-fimc/fimc-capture.c:1163:5: warning: symbol 'enclosed_rectangle' was not declared. Should it be static?

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Sachin Kamat 2012-05-26 11:11:54 -03:00 • committed by Mauro Carvalho Chehab
parent 50fbe32cf4
commit 7e566be258
4 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/media/video/s5p-fimc/fimc-capture.c
View file

@ -1161,7 +1161,7 @@ static int fimc_cap_g_selection(struct file *file, void *fh,
} }
/* Return 1 if rectangle a is enclosed in rectangle b, or 0 otherwise. */ /* Return 1 if rectangle a is enclosed in rectangle b, or 0 otherwise. */
int enclosed_rectangle(struct v4l2_rect *a, struct v4l2_rect *b) static int enclosed_rectangle(struct v4l2_rect *a, struct v4l2_rect *b)
{ {
if (a->left < b->left || a->top < b->top) if (a->left < b->left || a->top < b->top)
return 0; return 0;

2
drivers/media/video/s5p-fimc/fimc-core.c
View file

@ -463,7 +463,7 @@ void fimc_prepare_dma_offset(struct fimc_ctx *ctx, struct fimc_frame *f)
f->fmt->color, f->dma_offset.y_h, f->dma_offset.y_v); f->fmt->color, f->dma_offset.y_h, f->dma_offset.y_v);
} }
int fimc_set_color_effect(struct fimc_ctx *ctx, enum v4l2_colorfx colorfx) static int fimc_set_color_effect(struct fimc_ctx *ctx, enum v4l2_colorfx colorfx)
{ {
struct fimc_effect *effect = &ctx->effect; struct fimc_effect *effect = &ctx->effect;

2
drivers/media/video/s5p-fimc/fimc-lite-reg.c
View file

@ -215,7 +215,7 @@ void flite_hw_set_camera_bus(struct fimc_lite *dev,
flite_hw_set_camera_port(dev, s_info->mux_id); flite_hw_set_camera_port(dev, s_info->mux_id);
} }
void flite_hw_set_out_order(struct fimc_lite *dev, struct flite_frame *f) static void flite_hw_set_out_order(struct fimc_lite *dev, struct flite_frame *f)
{ {
static const u32 pixcode[4][2] = { static const u32 pixcode[4][2] = {
{ V4L2_MBUS_FMT_YUYV8_2X8, FLITE_REG_CIODMAFMT_YCBYCR }, { V4L2_MBUS_FMT_YUYV8_2X8, FLITE_REG_CIODMAFMT_YCBYCR },

7
drivers/media/video/s5p-fimc/fimc-mdevice.c
View file

@ -180,7 +180,7 @@ EXPORT_SYMBOL_GPL(fimc_pipeline_initialize);
* sensor clock. * sensor clock.
* Called with the graph mutex held. * Called with the graph mutex held.
*/ */
int __fimc_pipeline_shutdown(struct fimc_pipeline *p) static int __fimc_pipeline_shutdown(struct fimc_pipeline *p)
{ {
int ret = 0; int ret = 0;
@ -1010,7 +1010,7 @@ static struct platform_driver fimc_md_driver = {
} }
}; };
int __init fimc_md_init(void) static int __init fimc_md_init(void)
{ {
int ret; int ret;
@ -1021,7 +1021,8 @@ int __init fimc_md_init(void)
return platform_driver_register(&fimc_md_driver); return platform_driver_register(&fimc_md_driver);
} }
void __exit fimc_md_exit(void)
static void __exit fimc_md_exit(void)
{ {
platform_driver_unregister(&fimc_md_driver); platform_driver_unregister(&fimc_md_driver);
fimc_unregister_driver(); fimc_unregister_driver();