evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

i2c: mux: gpio: Check gpio_direction_output return value

Browse source 
gpio_direction_output() may fail, check for that and deal with it
appropriately. Also log an error message if gpio_request() fails.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
This commit is contained in:
Jean Delvare 2013-03-06 22:35:53 +00:00 • committed by Wolfram Sang
parent 1b295c839b
commit 7fafae669a
1 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/i2c/muxes/i2c-mux-gpio.c
View file

@ -201,10 +201,21 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
for (i = 0; i < mux->data.n_gpios; i++) { for (i = 0; i < mux->data.n_gpios; i++) {
ret = gpio_request(gpio_base + mux->data.gpios[i], "i2c-mux-gpio"); ret = gpio_request(gpio_base + mux->data.gpios[i], "i2c-mux-gpio");
if (ret) if (ret) {
dev_err(&pdev->dev, "Failed to request GPIO %d\n",
mux->data.gpios[i]);
goto err_request_gpio; goto err_request_gpio;
gpio_direction_output(gpio_base + mux->data.gpios[i], }
ret = gpio_direction_output(gpio_base + mux->data.gpios[i],
initial_state & (1 << i)); initial_state & (1 << i));
if (ret) {
dev_err(&pdev->dev,
"Failed to set direction of GPIO %d to output\n",
mux->data.gpios[i]);
i++; /* gpio_request above succeeded, so must free */
goto err_request_gpio;
}
} }
for (i = 0; i < mux->data.n_values; i++) { for (i = 0; i < mux->data.n_values; i++) {