evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

scsi: ufs: increase fDeviceInit query response timeout

Browse source 
fDeviceInit query response time for some devices is too long that default
query request timeout of 100ms may not be enough. Experiments show that
fDeviceInit response sometimes takes 500ms so to be on safer side this
change sets the timeout to 600ms. Without this change, we might
unnecessarily have to retry fDeviceInit query requests multiple times and
each query request timeout prints one error message.

Change-Id: Ib44fef65c9e408201eb6e0ff9e02d0703d4bf5d9
Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
This commit is contained in:
Subhash Jadavani 2014-11-01 23:38:53 -07:00 • committed by David Keitel
parent f6418ef28c
commit 81be613925
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/scsi/ufs/ufshcd.c
View file

@ -124,6 +124,12 @@
#define QUERY_REQ_RETRIES 10 #define QUERY_REQ_RETRIES 10
/* Query request timeout */ /* Query request timeout */
#define QUERY_REQ_TIMEOUT 100 /* msec */ #define QUERY_REQ_TIMEOUT 100 /* msec */
/*
* Query request timeout for fDeviceInit flag
* fDeviceInit query response time for some devices is too large that default
* QUERY_REQ_TIMEOUT may not be enough for such devices.
*/
#define QUERY_FDEVICEINIT_REQ_TIMEOUT 600 /* msec */
/* Task management command timeout */ /* Task management command timeout */
#define TM_CMD_TIMEOUT 100 /* msecs */ #define TM_CMD_TIMEOUT 100 /* msecs */
@ -2506,6 +2512,7 @@ int ufshcd_query_flag(struct ufs_hba *hba, enum query_opcode opcode,
struct ufs_query_req *request = NULL; struct ufs_query_req *request = NULL;
struct ufs_query_res *response = NULL; struct ufs_query_res *response = NULL;
int err, index = 0, selector = 0; int err, index = 0, selector = 0;
int timeout = QUERY_REQ_TIMEOUT;
BUG_ON(!hba); BUG_ON(!hba);
@ -2538,7 +2545,10 @@ int ufshcd_query_flag(struct ufs_hba *hba, enum query_opcode opcode,
goto out_unlock; goto out_unlock;
} }
err = ufshcd_exec_dev_cmd(hba, DEV_CMD_TYPE_QUERY, QUERY_REQ_TIMEOUT); if (idn == QUERY_FLAG_IDN_FDEVICEINIT)
timeout = QUERY_FDEVICEINIT_REQ_TIMEOUT;
err = ufshcd_exec_dev_cmd(hba, DEV_CMD_TYPE_QUERY, timeout);
if (err) { if (err) {
dev_err(hba->dev, dev_err(hba->dev,