evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

firewire: sbp2: octlet AT payloads can be stack-allocated

Browse source 
We do not need slab allocations for ORB pointer write transactions
anymore in order to satisfy streaming DMA mapping constraints, thanks to
commit da28947e7e "firewire: ohci: avoid separate DMA mapping for
small AT payloads".

(Besides, the slab-allocated buffers that firewire-sbp2 used to provide
for 8-byte write requests were still not fully portable since they
shared a cacheline with unrelated CPU-accessed data.)

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
This commit is contained in:
Stefan Richter 2011-05-01 21:06:42 +02:00
parent b75ca5ea8e
commit 81bf52d862
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/firewire/sbp2.c
View file

@ -258,7 +258,6 @@ struct sbp2_orb {
struct kref kref; struct kref kref;
dma_addr_t request_bus; dma_addr_t request_bus;
int rcode; int rcode;
struct sbp2_pointer pointer;
void (*callback)(struct sbp2_orb * orb, struct sbp2_status * status); void (*callback)(struct sbp2_orb * orb, struct sbp2_status * status);
struct list_head link; struct list_head link;
}; };
@ -490,10 +489,11 @@ static void sbp2_send_orb(struct sbp2_orb *orb, struct sbp2_logical_unit *lu,
int node_id, int generation, u64 offset) int node_id, int generation, u64 offset)
{ {
struct fw_device *device = target_device(lu->tgt); struct fw_device *device = target_device(lu->tgt);
struct sbp2_pointer orb_pointer;
unsigned long flags; unsigned long flags;
orb->pointer.high = 0; orb_pointer.high = 0;
orb->pointer.low = cpu_to_be32(orb->request_bus); orb_pointer.low = cpu_to_be32(orb->request_bus);
spin_lock_irqsave(&device->card->lock, flags); spin_lock_irqsave(&device->card->lock, flags);
list_add_tail(&orb->link, &lu->orb_list); list_add_tail(&orb->link, &lu->orb_list);
@ -504,7 +504,7 @@ static void sbp2_send_orb(struct sbp2_orb *orb, struct sbp2_logical_unit *lu,
fw_send_request(device->card, &orb->t, TCODE_WRITE_BLOCK_REQUEST, fw_send_request(device->card, &orb->t, TCODE_WRITE_BLOCK_REQUEST,
node_id, generation, device->max_speed, offset, node_id, generation, device->max_speed, offset,
&orb->pointer, 8, complete_transaction, orb); &orb_pointer, 8, complete_transaction, orb);
} }
static int sbp2_cancel_orbs(struct sbp2_logical_unit *lu) static int sbp2_cancel_orbs(struct sbp2_logical_unit *lu)