evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: cb_pcidas64: tidy up the *phys_iobase

Browse source 
This driver does not use the dev->iobase so don't bother initializing
it.

The plx9080_phys_iobase is not used in the driver. Remove it from the
private data.

Tidy up the initialization of the other phy_iobase variables.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2013-04-10 11:28:47 -07:00 • committed by Greg Kroah-Hartman
parent c71b2e52a0
commit 81d985a11e
1 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/staging/comedi/drivers/cb_pcidas64.c
View file

@ -1080,7 +1080,6 @@ struct ext_clock_info {
/* this structure is for data unique to this hardware driver. */ /* this structure is for data unique to this hardware driver. */
struct pcidas64_private { struct pcidas64_private {
/* base addresses (physical) */ /* base addresses (physical) */
resource_size_t plx9080_phys_iobase;
resource_size_t main_phys_iobase; resource_size_t main_phys_iobase;
resource_size_t dio_counter_phys_iobase; resource_size_t dio_counter_phys_iobase;
/* base addresses (ioremapped) */ /* base addresses (ioremapped) */
@ -4053,13 +4052,8 @@ static int auto_attach(struct comedi_device *dev,
/* Initialize dev->board_name */ /* Initialize dev->board_name */
dev->board_name = thisboard->name; dev->board_name = thisboard->name;
dev->iobase = pci_resource_start(pcidev, 2); devpriv->main_phys_iobase = pci_resource_start(pcidev, 2);
devpriv->dio_counter_phys_iobase = pci_resource_start(pcidev, 3);
devpriv->plx9080_phys_iobase =
pci_resource_start(pcidev, 0);
devpriv->main_phys_iobase = dev->iobase;
devpriv->dio_counter_phys_iobase =
pci_resource_start(pcidev, 3);
devpriv->plx9080_iobase = pci_ioremap_bar(pcidev, 0); devpriv->plx9080_iobase = pci_ioremap_bar(pcidev, 0);
devpriv->main_iobase = pci_ioremap_bar(pcidev, 2); devpriv->main_iobase = pci_ioremap_bar(pcidev, 2);