evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: zcache: fix length type mismatch

Browse source 
This fixes a type mismatch in the compression code where
a size_t pointer was cast to a unsigned int pointer.  On
little endian archs, there is no issue.  However on big
endian archs, the value is incorrect, taking the high
order bits and truncating the lower order bits.

Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Seth Jennings 2012-02-28 16:01:37 -06:00 • committed by Greg Kroah-Hartman
parent 0339d3dbbf
commit 843c666d16
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/staging/zcache/zcache-main.c
View file

@ -1170,14 +1170,14 @@ static atomic_t zcache_curr_pers_pampd_count = ATOMIC_INIT(0);
static unsigned long zcache_curr_pers_pampd_count_max; static unsigned long zcache_curr_pers_pampd_count_max;
/* forward reference */ /* forward reference */
static int zcache_compress(struct page *from, void **out_va, size_t *out_len); static int zcache_compress(struct page *from, void **out_va, unsigned *out_len);
static void *zcache_pampd_create(char *data, size_t size, bool raw, int eph, static void *zcache_pampd_create(char *data, size_t size, bool raw, int eph,
struct tmem_pool *pool, struct tmem_oid *oid, struct tmem_pool *pool, struct tmem_oid *oid,
uint32_t index) uint32_t index)
{ {
void *pampd = NULL, *cdata; void *pampd = NULL, *cdata;
size_t clen; unsigned clen;
int ret; int ret;
unsigned long count; unsigned long count;
struct page *page = (struct page *)(data); struct page *page = (struct page *)(data);
@ -1326,7 +1326,7 @@ static struct tmem_pamops zcache_pamops = {
static DEFINE_PER_CPU(unsigned char *, zcache_dstmem); static DEFINE_PER_CPU(unsigned char *, zcache_dstmem);
#define ZCACHE_DSTMEM_ORDER 1 #define ZCACHE_DSTMEM_ORDER 1
static int zcache_compress(struct page *from, void **out_va, size_t *out_len) static int zcache_compress(struct page *from, void **out_va, unsigned *out_len)
{ {
int ret = 0; int ret = 0;
unsigned char *dmem = __get_cpu_var(zcache_dstmem); unsigned char *dmem = __get_cpu_var(zcache_dstmem);
@ -1339,7 +1339,7 @@ static int zcache_compress(struct page *from, void **out_va, size_t *out_len)
from_va = kmap_atomic(from, KM_USER0); from_va = kmap_atomic(from, KM_USER0);
mb(); mb();
ret = zcache_comp_op(ZCACHE_COMPOP_COMPRESS, from_va, PAGE_SIZE, dmem, ret = zcache_comp_op(ZCACHE_COMPOP_COMPRESS, from_va, PAGE_SIZE, dmem,
(unsigned int *)out_len); out_len);
BUG_ON(ret); BUG_ON(ret);
*out_va = dmem; *out_va = dmem;
kunmap_atomic(from_va, KM_USER0); kunmap_atomic(from_va, KM_USER0);