evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

HID: picolcd: sanity check report size in raw_event() callback

Browse source 
The report passed to us from transport driver could potentially be
arbitrarily large, therefore we better sanity-check it so that raw_data
that we hold in picolcd_pending structure are always kept within proper
bounds.

Cc: stable@vger.kernel.org
Reported-by: Steven Vittitoe <scvitti@google.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Jiri Kosina 2014-08-27 09:13:15 +02:00
parent c54def7bd6
commit 844817e47e
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/hid/hid-picolcd_core.c
View file

@ -350,6 +350,12 @@ static int picolcd_raw_event(struct hid_device *hdev,
if (!data) if (!data)
return 1; return 1;
if (size > 64) {
hid_warn(hdev, "invalid size value (%d) for picolcd raw event\n",
size);
return 0;
}
if (report->id == REPORT_KEY_STATE) { if (report->id == REPORT_KEY_STATE) {
if (data->input_keys) if (data->input_keys)
ret = picolcd_raw_keypad(data, report, raw_data+1, size-1); ret = picolcd_raw_keypad(data, report, raw_data+1, size-1);