evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Staging: comedi: fix printk issue in cb_pcidas.c

Browse source 
This is a patch to the cb_pcidas.c file that fixes up a printk
warning found by the checkpatch.pl tool.

converted printks to dev_printk and Removed unnecessary
printk statements.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Ravishankar karkala Mallikarjunayya 2011-11-19 10:06:41 +05:30 • committed by Greg Kroah-Hartman
parent be545c6251
commit 8bde85db94
1 changed files with 7 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
drivers/staging/comedi/drivers/cb_pcidas.c
View file

@ -565,8 +565,6 @@ static int cb_pcidas_attach(struct comedi_device *dev,
int index; int index;
int i; int i;
printk("comedi%d: cb_pcidas: ", dev->minor);
/* /*
* Allocate the private structure area. * Allocate the private structure area.
*/ */
@ -576,7 +574,6 @@ static int cb_pcidas_attach(struct comedi_device *dev,
/* /*
* Probe the device to determine what device in the series it is. * Probe the device to determine what device in the series it is.
*/ */
printk("\n");
for_each_pci_dev(pcidev) { for_each_pci_dev(pcidev) {
/* is it not a computer boards card? */ /* is it not a computer boards card? */
@ -600,20 +597,20 @@ static int cb_pcidas_attach(struct comedi_device *dev,
} }
} }
printk("No supported ComputerBoards/MeasurementComputing card found on " dev_err(dev->hw_dev, "No supported ComputerBoards/MeasurementComputing card found on requested position\n");
"requested position\n");
return -EIO; return -EIO;
found: found:
printk("Found %s on bus %i, slot %i\n", cb_pcidas_boards[index].name, dev_dbg(dev->hw_dev, "Found %s on bus %i, slot %i\n",
pcidev->bus->number, PCI_SLOT(pcidev->devfn)); cb_pcidas_boards[index].name, pcidev->bus->number,
PCI_SLOT(pcidev->devfn));
/* /*
* Enable PCI device and reserve I/O ports. * Enable PCI device and reserve I/O ports.
*/ */
if (comedi_pci_enable(pcidev, "cb_pcidas")) { if (comedi_pci_enable(pcidev, "cb_pcidas")) {
printk(" Failed to enable PCI device and request regions\n"); dev_err(dev->hw_dev, "Failed to enable PCI device and request regions\n");
return -EIO; return -EIO;
} }
/* /*
@ -639,7 +636,8 @@ found:
/* get irq */ /* get irq */
if (request_irq(devpriv->pci_dev->irq, cb_pcidas_interrupt, if (request_irq(devpriv->pci_dev->irq, cb_pcidas_interrupt,
IRQF_SHARED, "cb_pcidas", dev)) { IRQF_SHARED, "cb_pcidas", dev)) {
printk(" unable to allocate irq %d\n", devpriv->pci_dev->irq); dev_dbg(dev->hw_dev, "unable to allocate irq %d\n",
devpriv->pci_dev->irq);
return -EINVAL; return -EINVAL;
} }
dev->irq = devpriv->pci_dev->irq; dev->irq = devpriv->pci_dev->irq;
@ -768,7 +766,6 @@ found:
*/ */
static int cb_pcidas_detach(struct comedi_device *dev) static int cb_pcidas_detach(struct comedi_device *dev)
{ {
printk("comedi%d: cb_pcidas: remove\n", dev->minor);
if (devpriv) { if (devpriv) {
if (devpriv->s5933_config) { if (devpriv->s5933_config) {