V4L/DVB: cx231xx: improve error handling
Return -EINVAL if we don't find the control id. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
f76280154c
commit
8e47567f7d
1 changed files with 4 additions and 1 deletions
|
@ -1902,9 +1902,12 @@ static int radio_queryctrl(struct file *file, void *priv,
|
||||||
if (c->id < V4L2_CID_BASE || c->id >= V4L2_CID_LASTP1)
|
if (c->id < V4L2_CID_BASE || c->id >= V4L2_CID_LASTP1)
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
if (c->id == V4L2_CID_AUDIO_MUTE) {
|
if (c->id == V4L2_CID_AUDIO_MUTE) {
|
||||||
for (i = 0; i < CX231XX_CTLS; i++)
|
for (i = 0; i < CX231XX_CTLS; i++) {
|
||||||
if (cx231xx_ctls[i].v.id == c->id)
|
if (cx231xx_ctls[i].v.id == c->id)
|
||||||
break;
|
break;
|
||||||
|
}
|
||||||
|
if (i == CX231XX_CTLS)
|
||||||
|
return -EINVAL;
|
||||||
*c = cx231xx_ctls[i].v;
|
*c = cx231xx_ctls[i].v;
|
||||||
} else
|
} else
|
||||||
*c = no_ctl;
|
*c = no_ctl;
|
||||||
|
|
Loading…
Add table
Reference in a new issue