evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

arm: tegra: fix error check in tegra2_clocks.c

Browse source 
Checking 'rate < 0' doesn't work because 'rate' is unsigned.

Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
Signed-off-by: Colin Cross <ccross@android.com>
This commit is contained in:
Nicolas Kaiser 2011-03-30 15:59:11 +02:00 • committed by Colin Cross
parent c8309ef6a4
commit 906c3b616d
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
arch/arm/mach-tegra/tegra2_clocks.c
View file

@ -1362,14 +1362,15 @@ static int tegra_clk_shared_bus_set_rate(struct clk *c, unsigned long rate)
{ {
unsigned long flags; unsigned long flags;
int ret; int ret;
long new_rate = rate;
rate = clk_round_rate(c->parent, rate); new_rate = clk_round_rate(c->parent, new_rate);
if (rate < 0) if (new_rate < 0)
return rate; return new_rate;
spin_lock_irqsave(&c->parent->spinlock, flags); spin_lock_irqsave(&c->parent->spinlock, flags);
c->u.shared_bus_user.rate = rate; c->u.shared_bus_user.rate = new_rate;
ret = tegra_clk_shared_bus_update(c->parent); ret = tegra_clk_shared_bus_update(c->parent);
spin_unlock_irqrestore(&c->parent->spinlock, flags); spin_unlock_irqrestore(&c->parent->spinlock, flags);