evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc: qcom: glink_pkt: Remove BUG_ON in glink_pkt_write

Browse source 
BUG_ON is called when error is returned from copy_from_user and
copy_to_user apis.

BUG_ON is removed and appropriate error value is returned after cleanup.

CRs-Fixed: 1102504
Change-Id: Ia995e60b8d8d335239be0a35876d1becfd9a0f3c
Signed-off-by: Dhoat Harpal <hdhoat@codeaurora.org>
This commit is contained in:
Dhoat Harpal 2016-12-19 19:13:15 +05:30
parent 3162449f7d
commit 90908adf31
1 changed files with 17 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
drivers/soc/qcom/msm_glink_pkt.c
View file

@ -664,7 +664,16 @@ ssize_t glink_pkt_read(struct file *file,
spin_unlock_irqrestore(&devp->pkt_list_lock, flags);
ret = copy_to_user(buf, pkt->data, pkt->size);
BUG_ON(ret != 0);
if (ret) {
GLINK_PKT_ERR(
"%s copy_to_user failed ret[%d] on dev id:%d size %zu\n",
__func__, ret, devp->i, pkt->size);
spin_lock_irqsave(&devp->pkt_list_lock, flags);
list_add_tail(&pkt->list, &devp->pkt_list);
spin_unlock_irqrestore(&devp->pkt_list_lock, flags);
return -EFAULT;
}
ret = pkt->size;
glink_rx_done(devp->handle, pkt->data, false);
@ -738,7 +747,13 @@ ssize_t glink_pkt_write(struct file *file,
}
ret = copy_from_user(data, buf, count);
BUG_ON(ret != 0);
if (ret) {
GLINK_PKT_ERR(
"%s copy_from_user failed ret[%d] on dev id:%d size %zu\n",
__func__, ret, devp->i, count);
kfree(data);
return -EFAULT;
}
ret = glink_tx(devp->handle, data, data, count, GLINK_TX_REQ_INTENT);
if (ret) {