evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

netlink: Delete an unnecessary check before the function call "module_put"

Browse source 
The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Markus Elfring 2015-07-02 18:38:12 +02:00 • committed by David S. Miller
parent f6e1c91666
commit 92b80eb33c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
net/netlink/af_netlink.c
View file

@ -158,7 +158,7 @@ static int __netlink_remove_tap(struct netlink_tap *nt)
out: out:
spin_unlock(&netlink_tap_lock); spin_unlock(&netlink_tap_lock);
if (found && nt->module) if (found)
module_put(nt->module); module_put(nt->module);
return found ? 0 : -ENODEV; return found ? 0 : -ENODEV;