evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

aoe: error printed 1 too early

Browse source 
with while (i-- > 0); i reaches -1 after the loop, so the test below is printed
one too early: 0 still means success.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Roel Kluin 2009-03-04 00:07:57 -08:00 • committed by David S. Miller
parent b9bdcd9bd7
commit 9487311157
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/block/aoe/aoedev.c
View file

@ -173,7 +173,7 @@ skbfree(struct sk_buff *skb)
return; return;
while (atomic_read(&skb_shinfo(skb)->dataref) != 1 && i-- > 0) while (atomic_read(&skb_shinfo(skb)->dataref) != 1 && i-- > 0)
msleep(Sms); msleep(Sms);
if (i <= 0) { if (i < 0) {
printk(KERN_ERR printk(KERN_ERR
"aoe: %s holds ref: %s\n", "aoe: %s holds ref: %s\n",
skb->dev ? skb->dev->name : "netif", skb->dev ? skb->dev->name : "netif",