evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Staging: comedi: Move a dereference below a NULL test

Browse source 
If the NULL test is necessary, then the dereference should be moved below
the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/).

// <smpl>
@disable is_null@
identifier f;
expression E;
identifier fld;
statement S;
@@

+ if (E == NULL) S
  f(...,E->fld,...);
- if (E == NULL) S

@@
identifier f;
expression E;
identifier fld;
statement S;
@@

+ if (!E) S
  f(...,E->fld,...);
- if (!E) S
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Julia Lawall 2008-12-26 08:28:58 +01:00 • committed by Greg Kroah-Hartman
parent b171041be0
commit 98ccdc56a0
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/staging/comedi/drivers/usbduxfast.c
View file

@ -1675,15 +1675,15 @@ static int usbduxfast_detach(comedi_device * dev)
{ {
usbduxfastsub_t *usbduxfastsub_tmp; usbduxfastsub_t *usbduxfastsub_tmp;
#ifdef CONFIG_COMEDI_DEBUG
printk("comedi%d: usbduxfast: detach usb device\n", dev->minor);
#endif
if (!dev) { if (!dev) {
printk("comedi?: usbduxfast: detach without dev variable...\n"); printk("comedi?: usbduxfast: detach without dev variable...\n");
return -EFAULT; return -EFAULT;
} }
#ifdef CONFIG_COMEDI_DEBUG
printk("comedi%d: usbduxfast: detach usb device\n", dev->minor);
#endif
usbduxfastsub_tmp = dev->private; usbduxfastsub_tmp = dev->private;
if (!usbduxfastsub_tmp) { if (!usbduxfastsub_tmp) {
printk("comedi?: usbduxfast: detach without ptr to usbduxfastsub[]\n"); printk("comedi?: usbduxfast: detach without ptr to usbduxfastsub[]\n");