evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mdss: mdp: fix invalid error check in rotator module

Browse source 
Invalid input/output format error checks in rotator module
is causing rotation request failure or wrong error message
print. This change fixes such invalid checks in rotator
module.

Change-Id: I0f5f19b65c6017dd16deaa09715d29335e551b01
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
This commit is contained in:
Dhaval Patel 2015-02-24 11:51:22 -08:00 • committed by David Keitel
parent a3eab01e8d
commit 9ae30a266c
1 changed files with 6 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
drivers/video/fbdev/msm/mdss_rotator.c
View file

@ -258,8 +258,9 @@ static int mdss_rotator_validate_data(struct mdss_rot_mgr *mgr,
}
fmt = mdss_mdp_get_format_params(input->format);
if (fmt) {
pr_err("invalid input format\n");
if (!fmt) {
pr_err("invalid input format:%d\n", input->format);
ret = -EINVAL;
goto validate_data_err;
}
@ -277,8 +278,9 @@ static int mdss_rotator_validate_data(struct mdss_rot_mgr *mgr,
}
fmt = mdss_mdp_get_format_params(output->format);
if (fmt) {
pr_err("invalid output format\n");
if (!fmt) {
pr_err("invalid output format:%d\n", output->format);
ret = -EINVAL;
goto validate_data_err;
}
@ -716,16 +718,6 @@ static u32 mdss_rotator_get_out_format(u32 in_format, bool rot90)
u32 format;
switch (in_format) {
case MDP_RGB_565:
case MDP_BGR_565:
if (rot90)
format = MDP_RGB_888;
else
format = in_format;
break;
case MDP_RGBA_8888:
format = in_format;
break;
case MDP_Y_CBCR_H2V2_VENUS:
case MDP_Y_CBCR_H2V2:
if (rot90)