From dbcf3eb96d10509662e387b1bccb1dfef0bc2a47 Mon Sep 17 00:00:00 2001 From: Prashanth Bhatta Date: Tue, 7 Mar 2017 14:41:25 -0800 Subject: [PATCH] icnss: Remove WARN_ON For QMI timeout issues ICNSS_ASSERT macro invokes WARN_ON but there can be cases of multiple QMI timeouts and those may cause to spit out lot of WARN_ON message to kernel log. Because of this, kernel log buffer may overlap and miss logs which may be of use for debugging the QMI timeout issue. Remove WARN_ON by making ICNSS_ASSERT as a dummy macro. Change-Id: I0d5d76a2385f40f64ec5d811f7bcde82f1c44877 CRs-fixed: 2016253 Signed-off-by: Prashanth Bhatta --- drivers/soc/qcom/icnss.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/soc/qcom/icnss.c b/drivers/soc/qcom/icnss.c index 4e541773c805..fc0e611f8c8b 100644 --- a/drivers/soc/qcom/icnss.c +++ b/drivers/soc/qcom/icnss.c @@ -110,13 +110,7 @@ module_param(qmi_timeout, ulong, 0600); } \ } while (0) #else -#define ICNSS_ASSERT(_condition) do { \ - if (!(_condition)) { \ - icnss_pr_err("ASSERT at line %d\n", \ - __LINE__); \ - WARN_ON(1); \ - } \ - } while (0) +#define ICNSS_ASSERT(_condition) do { } while (0) #endif enum icnss_debug_quirks {