evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pinctrl: pinctrl-imx.c: Cleaning up if unsigned is less than zero

Browse source 
Remove checking if a unsigned is less than zero

This was found using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Rickard Strandqvist 2014-06-26 13:28:16 +02:00 • committed by Linus Walleij
parent ca7162add9
commit 9eedfd688c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/pinctrl/pinctrl-imx.c
View file

@ -515,7 +515,7 @@ static int imx_pinctrl_parse_functions(struct device_node *np,
/* Initialise function */ /* Initialise function */
func->name = np->name; func->name = np->name;
func->num_groups = of_get_child_count(np); func->num_groups = of_get_child_count(np);
if (func->num_groups <= 0) { if (func->num_groups == 0) {
dev_err(info->dev, "no groups defined in %s\n", np->full_name); dev_err(info->dev, "no groups defined in %s\n", np->full_name);
return -EINVAL; return -EINVAL;
} }