evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

qbt1000: Validate FP app name before qseecom_start_app

Browse source 
Validate the name of the client app before passing it to
qseecom_start_app.

CRs-Fixed: 2006695
Change-Id: I9c6b16050d4f6fc94827021c7b0f2ab292452f60
Signed-off-by: Abir Ghosh <abirg@codeaurora.org>
This commit is contained in:
Abir Ghosh 2017-05-02 22:41:06 +05:30 • committed by Gerrit - the friendly Code Review server
parent 5d78c03af8
commit 9f6e16f245
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/soc/qcom/qbt1000.c
View file

@ -401,6 +401,13 @@ static long qbt1000_ioctl(struct file *file, unsigned cmd, unsigned long arg)
goto end; goto end;
} }
if (strcmp(app.name, FP_APP_NAME)) {
dev_err(drvdata->dev, "%s: Invalid app name\n",
__func__);
rc = -EINVAL;
goto end;
}
if (drvdata->app_handle) { if (drvdata->app_handle) {
dev_err(drvdata->dev, "%s: LOAD app already loaded, unloading first\n", dev_err(drvdata->dev, "%s: LOAD app already loaded, unloading first\n",
__func__); __func__);
@ -447,9 +454,7 @@ static long qbt1000_ioctl(struct file *file, unsigned cmd, unsigned long arg)
pr_debug("app %s load after\n", app.name); pr_debug("app %s load after\n", app.name);
if (!strcmp(app.name, FP_APP_NAME)) drvdata->fp_app_handle = drvdata->app_handle;
drvdata->fp_app_handle = drvdata->app_handle;
break; break;
} }
case QBT1000_UNLOAD_APP: case QBT1000_UNLOAD_APP: